Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs(button): remove MDX file #3636

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from
Draft

docs(button): remove MDX file #3636

wants to merge 3 commits into from
+146 −429

Conversation

marissahuysentruyt
Copy link
Collaborator

  • delete mdx file in favor of all docs being in stories file
  • update some story names to follow sentence-casing and organize like- stories together

Description

How and where has this been tested?

Please tag yourself on the tests you've marked complete to confirm the tests have been run by someone other than the author.

Validation steps

Regression testing

Validate:

  1. The documentation pages for at least two other components are still loading, including:
  • The pages render correctly, are accessible, and are responsive.
  1. If components have been modified, VRTs have been run on this branch:
  • VRTs have been run and looked at.
  • Any VRT changes have been accepted (by reviewer and/or PR author), or there are no changes.

Screenshots

To-do list

  • I have read the contribution guidelines.
  • I have updated relevant storybook stories and templates.
  • I have tested these changes in Windows High Contrast mode.
  • If my change impacts other components, I have tested to make sure they don't break.
  • If my change impacts documentation, I have updated the documentation accordingly.
  • ✨ This pull request is ready to merge. ✨

@marissahuysentruyt marissahuysentruyt self-assigned this Mar 21, 2025
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Mar 21, 2025 •
edited
Loading

⚠️ No Changeset found

Latest commit: d239ea4

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@marissahuysentruyt marissahuysentruyt added documentation Because documentation is important and shouldn't be broken wip This is a work in progress, don't judge. do not merge A flag for a branch indicating it should not be merged. labels Mar 21, 2025
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Mar 21, 2025 •
edited
Loading

File metrics

Summary

Total size: 2.24 MB*

🎉 No changes detected in any packages

* Size is the sum of all main files for packages in the library.
* An ASCII character in UTF-8 is 8 bits or 1 byte.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Mar 21, 2025 •
edited
Loading

🚀 Deployed on https://pr-3636--spectrum-css.netlify.app

@marissahuysentruyt
docs(button): remove MDX file
ff3f16f 
- delete mdx file in favor of all docs being in stories file
- update some story names to follow sentence-casing and organize like-
stories together
@marissahuysentruyt
docs(icon): remove MDX file
5bbc858 
- delete mdx file in favor of all docs being in stories file
- update some story names to follow sentence-casing and organize like-
stories together
- move some markup into template file instead of stories file
@marissahuysentruyt
docs(typography): remove MDX file
d239ea4 
- delete mdx file in favor of all docs being in stories file
- update some story names to follow sentence-casing and organize like-
stories together
@marissahuysentruyt marissahuysentruyt force-pushed the marissahuysentruyt/css-1051-refactor-button-icon-typography-mdx branch from 34edcc7 to d239ea4 Compare March 26, 2025 00:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@marissahuysentruyt marissahuysentruyt

Labels
do not merge A flag for a branch indicating it should not be merged. documentation Because documentation is important and shouldn't be broken wip This is a work in progress, don't judge.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@marissahuysentruyt